Skip to content

Commit

Permalink
Revert "fix: properly override database url properties (#6247)" (#6802)
Browse files Browse the repository at this point in the history
This reverts commit 0ba2a48.
  • Loading branch information
pleerock committed Sep 29, 2020
1 parent c1c8e88 commit 45b980c
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 20 deletions.
2 changes: 1 addition & 1 deletion src/driver/DriverUtils.ts
Expand Up @@ -28,7 +28,7 @@ export class DriverUtils {
if (buildOptions && buildOptions.useSid) {
urlDriverOptions.sid = parsedUrl.database;
}
return Object.assign({}, urlDriverOptions, options);
return Object.assign({}, options, urlDriverOptions);
}
return Object.assign({}, options);
}
Expand Down
19 changes: 0 additions & 19 deletions test/github-issues/4878/issue-4878.ts

This file was deleted.

1 comment on commit 45b980c

@samskiter
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pleerock I just opened #8922 referring tot his exact change. curious why this was reverted as the options are documented to overwrite the URL options

Please sign in to comment.