Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream is ignoring take and skip with join #10826

Open
1 of 18 tasks
aryelu opened this issue Apr 10, 2024 · 0 comments
Open
1 of 18 tasks

stream is ignoring take and skip with join #10826

aryelu opened this issue Apr 10, 2024 · 0 comments

Comments

@aryelu
Copy link

aryelu commented Apr 10, 2024

Issue description

stream is ignoring take and skip

Expected Behavior

Expecting to have the results paginated

Actual Behavior

All rows are returning without pagination

Steps to reproduce

repository.createQueryBuilder('dog')
            .innerJoinAndMapOne('dog.joined', DogJoin, 'joined', 'dog.id = joined.id')
.take(5)
.skip(5)

My Environment

Dependency Version
Operating System
TypeORM version 0.2.41

Additional Context

SelectQueryBuilder with getMany has a particular case for take and skip, while stream doesn't

Relevant Database Driver(s)

  • aurora-mysql
  • aurora-postgres
  • better-sqlite3
  • cockroachdb
  • cordova
  • expo
  • mongodb
  • mysql
  • nativescript
  • oracle
  • postgres
  • react-native
  • sap
  • spanner
  • sqlite
  • sqlite-abstract
  • sqljs
  • sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, but I don't know how to start. I would need guidance.

@aryelu aryelu changed the title stream is ignoring take and skip stream is ignoring take and skip with join Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant