Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update child's mpath even if parentId was soft-deleted in TreeRepository #10844

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: Update child's mpath even if parentId was soft-deleted in TreeRepository #10844

wants to merge 2 commits into from

Conversation

JoseCToscano
Copy link
Contributor

@JoseCToscano JoseCToscano commented Apr 23, 2024 •
edited

Include soft-deleted entities in queryBuilder to fetch required parent's path even if parent is soft deleted. This path is required to perforn the corresponding update of the childs' mpath

fix #10843

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@JoseCToscano
fix: Update child's mpath even if parentId was soft-deleted in TreeRe…
fdbe3fc 
…pository

Include soft-deleted entities in queryBuilder to fetch required parent's path
even if parent is soft deleted. This path is required to perforn the corresponding
update of the childs' mpath

fix typeorm#10843
@JoseCToscano
applied prettier fix
eaa893f
JoseCToscano
JoseCToscano commented Apr 23, 2024
View reviewed changes
src/persistence/tree/MaterializedPathSubjectExecutor.ts
@@ -172,6 +172,7 @@ export class MaterializedPathSubjectExecutor {
}
}),
)
.withDeleted()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main change of the PR

@JoseCToscano
Copy link
Contributor Author

JoseCToscano commented Apr 24, 2024 •
edited

Could we retry running the "failed" test? It seems it has timedout
Screenshot 2024-04-24 at 11 12 56 a m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TreeRepository does not update mpath if parentId was soft-deleted
1 participant
@JoseCToscano