Where drops wrong entity properties silently

[spech66]

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[x] mysql / mariadb
[ ] oracle
[ ] postgres
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

class User {
    Email!: string;
}

class export class UserRepository extends AbstractRepository<User> {
    public getByEmail(mail: string): Promise<User | undefined> {
        return this.repository.findOne({where: { Email: mail }});
    }
}

This works es expected.

query: SELECT ... FROM `user` `User` WHERE `User`.`email` = ? -- PARAMETERS: ["u1@test.test"]

However if I change the Email in the where clause to email or anything different the query is executed without the where clause.

        return this.repository.findOne({where: { email: mail }});
        return this.repository.findOne({where: { x: mail }});

query: SELECT ... FROM `user` `User`

Shouldn't this throw an exception of missing columns instead?

[spech66]

Isn't this a major problem for queries?

[vlapo]

Closing in favor of #3416