-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setting COMMENT on columns and tables (PostgreSQL) #3360
Comments
Feature is opened for contributions! |
This should be fixed also for mysql. And investigate comments in all supported databases and implemented it too. |
Please save comment in meta first. It helps generating API docs. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
+1 |
adds support for column comments to both the Postgres and CockroachDB driver - for migrations & in metadata. also includes new tests that validate the functionality works as expected updates the MySQL support so there's better handling of the column comments in MySQL so it also passes the column comment tests fixes typeorm#3360
adds support for column comments to both the Postgres and CockroachDB driver - for migrations & in metadata. also includes new tests that validate the functionality works as expected updates the MySQL support so there's better handling of the column comments in MySQL so it also passes the column comment tests fixes typeorm#3360
adds support for column comments to both the Postgres and CockroachDB driver - for migrations & in metadata. also includes new tests that validate the functionality works as expected updates the MySQL support so there's better handling of the column comments in MySQL so it also passes the column comment tests fixes typeorm#3360
Code in #6902 is ready to go, has tests, should be good to merge. |
adds support for column comments to both the Postgres and CockroachDB driver - for migrations & in metadata. also includes new tests that validate the functionality works as expected updates the MySQL support so there's better handling of the column comments in MySQL so it also passes the column comment tests fixes typeorm#3360
adds support for column comments to both the Postgres and CockroachDB driver - for migrations & in metadata. also includes new tests that validate the functionality works as expected fixes typeorm#3360
adds support for column comments to both the Postgres and CockroachDB driver - for migrations & in metadata. also includes new tests that validate the functionality works as expected fixes #3360
adds support for column comments to both the Postgres and CockroachDB driver - for migrations & in metadata. also includes new tests that validate the functionality works as expected fixes typeorm#3360
Has this feature been implemented for mysql databases ? |
@Entity({comment: 'A user profile in the wep app.'})
export class User {
...
} Is this option not implemented? |
Don't think so. Looks like as part of the PR #6902, only column comments support was added. Is there a different issue for table comments support? |
@vlapo, I'm facing the same issue as mentioned above by @derushio and @nawaz-pasha . |
Any news to table comments? (MySQL) It would be good if it were implemented to EntitySchema as well |
can we reopen this ? i dont think that table comments are implemented |
table comments are not implement |
Issue type:
[ ] question
[ ] bug report
[x] feature request
[ ] documentation issue
Database system/driver:
[ ]
cordova
[ ]
mongodb
[ ]
mssql
[ ]
mysql
/mariadb
[ ]
oracle
[x]
postgres
[ ]
sqlite
[ ]
sqljs
[ ]
react-native
[ ]
expo
TypeORM version:
[x]
latest
[ ]
@next
[ ]
0.x.x
(or put your version here)Feature request:
When I define my entities I would like to be able to set a COMMENT to the database object. From looking at the source code this seems to be currently possible only for MySQL and not for PostgreSQL:
Using PostgreSQL one can also set a COMMENT on the table itself, which is not yet supported by TypeORM at all, but could look like this:
I am asking for this feature as I am using the awesome PostGraphile tool, which heavily relies on COMMENTs for its configuration, and it would be really useful to do this by using TypeORM entity decorators!!
Many thanks,
Ulrich
The text was updated successfully, but these errors were encountered: