TypeORM migration:generate produces pointless migration changes

[vladimirmoushkov]

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[x] postgres
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:
Add an following entity to existing TypeORM projecT:

import { Column, Entity, Index, JoinColumn, ManyToOne, PrimaryGeneratedColumn } from "typeorm";
import { User } from "./User";

@Entity()
export class Session {
    @PrimaryGeneratedColumn()
    public id: number;

    @ManyToOne(() => User)
    @JoinColumn()
    public user: User;

    @Column({type: "char", precision: 64, nullable: false})
    @Index({unique: true})
    public sessionId: string;

    @Column()
    public validTo: Date;

    @Column()
    public lastActive: Date;
 }

Generate a migration using:

ts-node ../../../node_modules/.bin/typeorm migration:generate -n AnyName

It will produce initial migration that contains Session table creation. Then run the migration as:

ts-node ../../../node_modules/.bin/typeorm migration:run

And then re-run the migration generation

ts-node ../../../node_modules/.bin/typeorm migration:generate -n AnyName2

Result of that will be migration that regenerates sessionId column. If the entity lacks precision specifier, and the above scenario is re-ran it will produce no second AnyName2 migration.

The issue is similar to these ones where the precision triggers non existing difference observation by the migration generator:
#1960
#2943

[corocn]

Same issue to me. "Date" column continues to generate migration files that have pointless alter sql command.

[hungneox]

Is there any news on this? I also have the same issue.

[volnyansky]

@hungneox I fixed it with @column({type:"datetime",precision:0})

[Kononnable]

@vladimirmoushkov

Result of that will be migration that regenerates sessionId column.

You shouldn't use precision on char column. Precision property is intended only for some numeric types. You should set length property instead.

As for datetime and precision - it will be fixed in 0.3.0 after merging #3262

[wasims1]

anyone knows how to solve this issue? i have the same problem and it's getting rediculous..

[stouch]

Same problem here.

[spmsupun]

it's 2021 and it's still happening :(

[dilpazir-whizpool]

2022 and still happening.
Version using: 0.2.41 (latest)