Zero as a discriminator value #3891
Assignees
Labels
Comments
|
I added to just that location. Wasn't enough. Somewhere else must be checking... |
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this issue
Oct 25, 2020
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this issue
Oct 26, 2020
this allows discriminator values like 0, "", or `null` fixes typeorm#3891
|
Ok - ran into some weirdness but we should be good to go. Waiting on tests to pass then I'll open a PR! |
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this issue
Oct 26, 2020
this allows discriminator values like 0, "", or `null` fixes typeorm#3891
7 tasks
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this issue
Oct 26, 2020
allow discriminator values in Single Table Inheritance like 0, "", or `null` fixes typeorm#3891
pleerock
pushed a commit
that referenced
this issue
Oct 26, 2020
allow discriminator values in Single Table Inheritance like 0, "", or `null` fixes #3891
dolsup
pushed a commit
to dolsup/typeorm
that referenced
this issue
Nov 3, 2020
allow discriminator values in Single Table Inheritance like 0, "", or `null` fixes typeorm#3891
zaro
pushed a commit
to zaro/typeorm
that referenced
this issue
Jan 12, 2021
allow discriminator values in Single Table Inheritance like 0, "", or `null` fixes typeorm#3891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to this line, I am unable to use
0as a discriminator value. Is this intended?typeorm/src/decorator/entity/ChildEntity.ts
Line 18 in b91a725
Currently working around it by starting the enum I use to hold the discriminators from
1.The text was updated successfully, but these errors were encountered: