findOneOrFail(null) or findOneOrFail(undefined) should throw error

[lleohao]

Issue type:

[ ] question
[ x ] bug report
[ ] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ x ] mssql
[ ] mysql / mariadb
[ ] oracle
[ ] postgres
[ ] cockroachdb
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[ x ] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

// category entity
import { Column, Entity, PrimaryGeneratedColumn } from 'typeorm';

@Entity()
export class CategoryEntity {
    @PrimaryGeneratedColumn()
    id: number;

    @Column({
        unique: true,
    })
    name: string;
}

// create one category
const  categryEntity = new CategoryEntity()
categryEntity.name = 'first';

await getRepository(CategoryEntity).save(categryEntity);

// findOneOrFail
const result = getRepository(CategoryEntity).findOneOrFail(null);
// expect throw error but result.toEqual(categryEntity)

[likyh]

+1

[jelling]

This needs to be fixed asap imo. If a null value is passed into a query TypeORM is retrieving a random record. This could cause serious data issues for someone.

[btorresbrandcoders]

Can verify that the same issue is occurring with PostgreSQL as well. This is a serious bug and should be getting more attention. The fact that a random record is returned is very concerning.

[dtmzr]

I recognized the same behavior on postgres.
I passed a parameter id straight to the method, whenever the id was undefined I had the same behavior.
However, passing an object works.

// This doesn't throw
function getCategoryById(id) {
  return getRepository(CategoryEntity).findOneOrFail(id);
}

// This throws
function getCategoryById(id) {
  return getRepository(CategoryEntity).findOneOrFail({ id });
}

I think this is related to the method overloading here.

[mgibson91]

As @dtmzr mentioned, I experienced the first record always getting returned when where conditions weren't met using the following syntax:

Entity.findOneOrFail({ where: { id: userId } }) (expected this to work from other typeorm experience.

It did however, work after removing the where:

Entity.findOneOrFail({ id: userId })

Confusing overloading

[imnotjames]

duplicate of 2990

[dtmzr]

Hey, @imnotjames the # was missing and therefore was not referenced.

[imnotjames]

Oops

duplicate of #2990

[apflieger]

I just upgraded to 0.2.29 but it still happen 😢