Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@CavidM @pleerock This seems to cause an error for connection configs with replication. Please note the lack of the database property on the root object. #4753

Closed
CavidM opened this issue Sep 16, 2019 · 3 comments · Fixed by #4826

Comments

@CavidM
Copy link
Contributor

CavidM commented Sep 16, 2019

@CavidM @pleerock This seems to cause an error for connection configs with replication. Please note the lack of the database property on the root object.

Example config:

{
  type: "mysql",
  replication: {
    master: {
      host: "DB_HOST",
      port: "DB_PORT",
      username: "DB_USER",
      password: "DB_PASSWORD",
      database: "DB_NAME"
    },
    slaves: [
      {
        host: "RO_DB_HOST",
        port: "DB_PORT",
        username: "DB_USER",
        password: "DB_PASSWORD",
        database: "DB_NAME"
      }
    ]
  },
  entities: [...]
};

Originally posted by @cajames in #4694 (comment)

@j-tegen
Copy link

j-tegen commented Sep 16, 2019

Having the same issues at the moment. Would you recommend fixing the typeorm version or adding the database property to the root object until this is fixed?

@CavidM
Copy link
Contributor Author

CavidM commented Sep 16, 2019

Yes, for now you can use v0.2.18.

@elthrasher elthrasher mentioned this issue Sep 28, 2019
@elthrasher
Copy link
Contributor

My team was impacted by this as well. Please give #4826 a look.

Ginden added a commit to Ginden/typeorm that referenced this issue Mar 22, 2022
Ginden added a commit to Ginden/typeorm that referenced this issue Mar 22, 2022
Ginden added a commit to Ginden/typeorm that referenced this issue Mar 22, 2022
Ginden added a commit to Ginden/typeorm that referenced this issue Mar 22, 2022
Ginden added a commit to Ginden/typeorm that referenced this issue Mar 22, 2022
Ginden added a commit to Ginden/typeorm that referenced this issue Mar 22, 2022
Ginden added a commit to Ginden/typeorm that referenced this issue Mar 23, 2022
Ginden added a commit to Ginden/typeorm that referenced this issue Mar 23, 2022
pleerock pushed a commit that referenced this issue Mar 23, 2022
* feat: support for Common Table Expressions

Resolves #1116 #5899

* test: disable test for #4753 if no MySQL is present in ormconfig.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants