Add schema name to the table path for Oracle driver

[mrcatlait]

Issue type:

[ ] question
[ ] bug report
[x] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[x] oracle
[ ] postgres
[ ] cockroachdb
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

Entity metadata doesn't have schema name in tablePath for Oracle driver:

typeorm/src/metadata/EntityMetadata.ts

Lines 850 to 868 in b99b4ad

	/**
	* Builds table path using database name, schema name and table name.
	*/
	protected buildTablePath(): string {
	let tablePath = this.tableName;
	if (this.schema && ((this.connection.driver instanceof PostgresDriver) || (this.connection.driver instanceof SqlServerDriver) || (this.connection.driver instanceof SapDriver))) {
	tablePath = this.schema + "." + tablePath;
	}
	if (this.database && !(this.connection.driver instanceof PostgresDriver)) {
	if (!this.schema && this.connection.driver instanceof SqlServerDriver) {
	tablePath = this.database + ".." + tablePath;
	} else {
	tablePath = this.database + "." + tablePath;
	}
	}
	return tablePath;
	}

As a result it is possible to query tables only with public synonym.
Could OracleDriver be added to the list of drivers which support schema name in tablePath?

[pirouet]

Hi,

I have pushed a fix through under #5805 for this

[lipeavelar]

I'm facing this issue, any updates about this?

[pirouet]

@lipeavelar Not sure how long it takes but I have a Pull Request (#6133) to add it back in waiting

[lipeavelar]

I think this issue should be closed, since #6673 should solve it

[pirouet]

Yep, agreed but I can't close it myself :(