Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested set: hardcoded property names for nsleft/nsright #5633

Closed
steerio opened this issue Mar 6, 2020 · 3 comments
Closed

Nested set: hardcoded property names for nsleft/nsright #5633

steerio opened this issue Mar 6, 2020 · 3 comments

Comments

@steerio
Copy link
Contributor

steerio commented Mar 6, 2020

Issue type:

[x] question
[ ] bug report
[x] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[ ] mysql / mariadb
[ ] oracle
[ ] postgres
[ ] cockroachdb
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

I need to work with a legacy database, and modifying the column names is off the table. Some of the tables are nested sets, which is fine, as TypeORM supports that.

It appears, though, that the names of the left and right columns are not configurable through the decorators, they are all hardcoded in EntityMetadataBuilder to be nsleft and nsright respectively.

Is there a reason behind this decision?

@danielsantiago
Copy link

I find the same problem

@steerio
Copy link
Contributor Author

steerio commented Apr 21, 2020

My proposed solution: #5737

@steerio
Copy link
Contributor Author

steerio commented Oct 14, 2021

The solution has since been merged, but I forgot to close this issue. My bad.

@steerio steerio closed this as completed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants