Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eager relation skips children relations #5685

Merged
merged 1 commit into from Jul 11, 2021
Merged

fix: eager relation skips children relations #5685

merged 1 commit into from Jul 11, 2021

Conversation

satanTime
Copy link
Contributor

@satanTime satanTime commented Mar 14, 2020

Closes #5169
Closes #5684

@satanTime satanTime changed the title fix: eager relation skips children relations #5684 fix: eager relation skips children relations Mar 15, 2020
@satanTime
Copy link
Contributor Author

Hi @pleerock,

the PR has been updated.

@satanTime
Copy link
Contributor Author

Hi @pleerock, could you review the PR?

@satanTime
Copy link
Contributor Author

Hi @pleerock, could you take a look?

@satanTime
Copy link
Contributor Author

Hi @pleerock, please let me know when you could review it.

@satanTime
Copy link
Contributor Author

Hey @pleerock, ping.

@satanTime
Copy link
Contributor Author

Hi @pleerock,

could you take a look at this PR when you have time? I think, the related issue is important.

@satanTime
Copy link
Contributor Author

satanTime commented Jun 30, 2021

Hi @pleerock, @imnotjames,

I hope this finds you well.
Might you take a look at the PR? It is waiting for a review more than a year.

Thank you in advance.

Copy link
Contributor

@imnotjames imnotjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the Oracle and docker changes.

ormconfig.oracle.json Outdated Show resolved Hide resolved
docker/oracle/docker-entrypoint.sh Outdated Show resolved Hide resolved
test/utils/test-utils.ts Outdated Show resolved Hide resolved
@satanTime
Copy link
Contributor Author

Hi @imnotjames,

the PR has been updated to contain only the related changes.

Copy link
Contributor

@imnotjames imnotjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could refactor the leftJoin and addSelect to make this less of an issue but for now this makes sense.

@imnotjames imnotjames merged commit e7e887a into typeorm:master Jul 11, 2021
@imnotjames
Copy link
Contributor

Thanks for your contribution!

@satanTime
Copy link
Contributor Author

Hi @imnotjames, thank you too!

It is nice to see, that there is a movement in the lib development after such a long time.
It is a cool lib, but, unfortunately, its maintenance was horrible.

@imnotjames
Copy link
Contributor

Hi @imnotjames, thank you too!

It is nice to see, that there is a movement in the lib development after such a long time.
It is a cool lib, but, unfortunately, its maintenance was horrible.

Maintenance of such a large project is an incredibly demanding and difficult task - so I definitely wouldn't call any other work on this horrible. There's just times where your priorities may not align with the maintainers. 😄 Like keeping food on the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An eager relationship skips children relationships nested relations ignored if parent is eager
2 participants