New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eager relation skips children relations #5685
Conversation
Hi @pleerock, the PR has been updated. |
Hi @pleerock, could you review the PR? |
Hi @pleerock, could you take a look? |
Hi @pleerock, please let me know when you could review it. |
Hey @pleerock, ping. |
Hi @pleerock, could you take a look at this PR when you have time? I think, the related issue is important. |
Hi @pleerock, @imnotjames, I hope this finds you well. Thank you in advance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove all the Oracle and docker changes.
Hi @imnotjames, the PR has been updated to contain only the related changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could refactor the leftJoin
and addSelect
to make this less of an issue but for now this makes sense.
Thanks for your contribution! |
Hi @imnotjames, thank you too! It is nice to see, that there is a movement in the lib development after such a long time. |
Maintenance of such a large project is an incredibly demanding and difficult task - so I definitely wouldn't call any other work on this horrible. There's just times where your priorities may not align with the maintainers. 😄 Like keeping food on the table. |
Closes #5169
Closes #5684