fix: postgresql connection URL can use an UNIX Socket

[paeolo]

Solves #2614.

• Current behavior:
  Users may provide an URL in the connection options which is parsed by a generic function to fill the following fields: host, port, username, password, database.
• Issue:
  You can't give an UNIX socket as host with PostgreSQL.
• Corrected behavior:
  Provide a ConnectionUrlParser class with different parser functions. The default parser function is left unchanged to prevent any regression with other database types. Concerning PostgreSQL a new function is provided which solves the issue. To prevent any regression, I tested myself the function with multiples strings against the default parser.
• Exemple of tested strings
  postgres://user:password@host:5432/database (standard)
  postgres://user:password@/var/run/postgresql?dbname=database (UNIX socket)
  postgres:///var/run/postgresql?dbname=database (without username)

[pleerock]

Thanks for contribution.

You probably don't have to use DriverUtils at all. Just create a local function in postgres driver - that's it. DriverUtils was created for common usage, if some driver have its own logic, better if it won't use DriverUtils at all and use its own implementation.

Also, few other notes:

• is there some popular package that is able to perform URL parsing? (to prevent extra maintainable code in the codebase). If no, that's fine.
• can we have a tests for this feature?

[paeolo]

You're welcome!

• Yes there is: https://www.npmjs.com/package/pg-connection-string. I wanted to use this package first but wasn't sure about the dependencies policies, since there are only a few dependencies in the package.json.
• Yes I can make a test.
  Paul.

[pleerock]

I would like to prevent extra dependencies, because people who use mysql don't need pg-connection-string. I checked, it looks like pg-connection-string is installed when you install pg itself, and since this code is running only when pg is used, maybe we can just add a check if pg-connection-string and use it? (dynamic require). If nothing was found - throw an exception (not possible case I guess)

[paeolo]

That's fine for me. I don't have time to do it this week-end but I can do it next week;)
Paul.

[paeolo]

@pleerock Seems better now.
Paul.

[guillenotfound]

Any update on this? 😄

[paeolo]

Any update on this?

It's ready for merge, waiting for @pleerock to review it.

[guillenotfound]

I used what's described here and was able to connect from cloud run: #2614 (comment)

[imnotjames]

Dropping this line drops something specifically for Oracle & the URL parsing which we don't want anyway.

Sounds good to me!

[imnotjames]

Thanks for the contribution!