Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrmUtils in 0.2.25 breaks browser builds due to node import #6142

Closed
chriswep opened this issue May 27, 2020 · 3 comments
Closed

OrmUtils in 0.2.25 breaks browser builds due to node import #6142

chriswep opened this issue May 27, 2020 · 3 comments

Comments

@chriswep
Copy link
Contributor

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue
TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Steps to reproduce or a small repository showing the problem:

using the .save() method (sometimes?) produces the error TypeError: Right hand side of instanceof is not an object which is triggered by OrmUtils.compare2Objects. Since 50a0641 this uses the node-import url which is not available on browser targets. I guess this needs to be removed or polyfilled in browser/utils/Ormutils.

@allandiego
Copy link
Contributor

Having the same error:

The package at "node_modules\typeorm\browser\util\OrmUtils.js" attempted to import the Node standard library module "url". It failed because the native React runtime does not include the Node standard library.

@pleerock
Copy link
Member

fixed by #6145

@imnotjames
Copy link
Contributor

This is indeed fixed & has been released. Bummer that we had to revert it. ):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants