softRemove DeleteDateColumn is null at Susbscriber's AfterUpdate method

[aykutcan]

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue

Database system/driver:

[ ] cordova
[ ] mongodb
[ ] mssql
[x] mysql / mariadb
[ ] oracle
[ ] postgres
[ ] cockroachdb
[ ] sqlite
[ ] sqljs
[ ] react-native
[ ] expo

TypeORM version:

[x] latest
[ ] @next
[ ] 0.x.x (or put your version here)

Problem

softRemove() method triggers afterUpdate() without specified @DeleteDateColumn

I cant access deleted_at column to detect deletion of that entity and remove it from elasticsearch

Steps to reproduce or a small repository showing the problem:

Create User Entity with DeleteDateColumn decorator

@Entity({ name: 'users' })
export class User {

...

    @Index('users.deleted_at')
    @DeleteDateColumn({ name: 'deleted_at' })
    deleted_at: Date;

...

}

Create UserSubscriber

@EventSubscriber()
export class UserSubscriber implements EntitySubscriberInterface<User> {
    listenTo() {
        return User;
    }

    afterUpdate(event: UpdateEvent<User>): any {
        console.log(`AFTER UPDATE: `, event.entity);
    }

}

Trigger softRemove on an entity

    let user = await userRepository.findOne(5);
    await userRepository.softRemove(user);

What it should do

Return removed entity with deleted_at column filled

What it does

Return entity with null deleted_at column

[cantoute]

+1: same with sqlite

[lucasbemol]

+1: same with postgresql

[spotykatch]

So, we've got a bug here, I guess, but that still does not solve the problem. The function should return isDeleteDate or there should be a function for softRemove.

typeorm/src/query-builder/ReturningResultsEntityUpdator.ts

Line 193 in a868078

return column.isUpdateDate || column.isVersion;

For some reason, this returns undefined.

typeorm/src/query-builder/ReturningResultsEntityUpdator.ts

Line 62 in a868078

const loadedReturningColumns = await this.queryRunner.manager

Oh, yea. Query builder should use .withDeleted().

[spotykatch]

And the last one.

typeorm/src/persistence/SubjectExecutor.ts

Line 738 in a868078

if (this.updateSubjects.length)

Must be

// update soft-removed entity properties
if (this.softRemoveSubjects.length)
    this.updateSpecialColumnsInInsertedAndUpdatedEntities(this.softRemoveSubjects);

// update recovered entity properties
if (this.recoverSubjects.length)
    this.updateSpecialColumnsInInsertedAndUpdatedEntities(this.recoverSubjects);

[sofia-cloudman]

+1 here

[zeek89]

hi there, any chances this will be fixed any time soon?

[alls23]

I need a lot this fix

[spotykatch]

The pr is been sent. But I don't have much experience with it. First CircleCI builds for cockroach failed due to timeout. Merge with the new version of typeorm passed the tests. But merge doesn't seem to be included in the pr. If you can help me with it, I would be very grateful.
PR: #8227

[zeek89]

hi spotykatch, first of all thanks for your work!
I am afraid we can do nothing but wait until someone merges the PR.