fix: Fix Mongodb delete by ObjectId. Closes #6552 #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I understand it - without this change only the second of the two test cases pass? EDIT: Ah, not even that, ok. |
|
Can you add the case of the previous required behavior? You'd mentioned it in the #6552
If you add that to detect any regressions I think this is more or less good to go. |
|
@imnotjames I added the regression test as suggested. You are correct, before this fix:
|
|
Thanks for the contribution! |
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
* fix: Fix Mongodb delete by ObjectId. Closes typeorm#6552 * add regression test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.