fix: add dummy for FileLogger, ConnectionOptionsReaders, and update gulpfile #6763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
changed the title
imnotjames
force-pushed
the
fix/browser-dummys
branch
from
49e8cfa
to
f86a21c
Compare
|
We still don't have a way to automatically test this kind of thing - technically it wasn't preventing folks from building TypeORM for browsers but it was making the build they'd have to make larger than desirable. I've been experimenting with a few different techniques for validating the builds but I think our best bet would be to use something like webpack or rollup to generate the browser build - those packages will do static analysis of our project to verify that we aren't pulling in any node specific code. Problem is.. those are a bit more involved of solutions & I was hoping to get this fixed for the next patch release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add browser dummies for
FileLogger,ConnectionOptionsReader, and change how we process the*.templatefiles ingulp.Ideally, we should move away from this whole process for creating browser builds by monkey-patching random parts of TypeORM in this way - such as restructuring the package or finding some other mechanism to make this happen.. but until then, this solves some of the remaining issues with browser builds according to @chriswep
Fixes #6739