Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes TS errors in EntityCreateCommand & SubscriberCreateCommand #6824

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

imnotjames
Copy link
Contributor

somehow #6807 passed as a PR but failed when merged in - this fixes the issues
that cropped up after it was merged in

…reateCommand

somehow typeorm#6807 passed as a PR but failed when merged in - this fixes the issues
that cropped up after it was merged in
@imnotjames
Copy link
Contributor Author

🙇 Not sure how I missed this when merging it in but here we are.

@imnotjames
Copy link
Contributor Author

I had to kick the build a few times - looked like somewhere between CircleCI, docker, and dockerhub there's been some errors today ):

@pleerock pleerock merged commit 0221a93 into typeorm:master Oct 1, 2020
@pleerock
Copy link
Member

pleerock commented Oct 1, 2020

👍

@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 7, 2020
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
…reateCommand (typeorm#6824)

somehow typeorm#6807 passed as a PR but failed when merged in - this fixes the issues
that cropped up after it was merged in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted label hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants