fix: return null for nullable RelationId() column #6848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where attempting to cast bigints to strings also did it for null values. Fix issue where transformRelationIds() filtered out null values when it should only be done for undefined. Closes: typeorm#6815
|
Thank you! |
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
Fix issue where attempting to cast bigints to strings also did it for null values. Fix issue where transformRelationIds() filtered out null values when it should only be done for undefined. Closes: typeorm#6815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where attempting to cast bigints to strings also did it for
null values.
Fix issue where transformRelationIds() filtered out null values when
it should only be done for undefined.
Closes: #6815