refactor: check mysql constraint schema on join #6851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are already in place - so as long as the tests pass for the previous PR I think this is good to merge in. |
imnotjames
force-pushed
the
refactor/rc-constraint-schema
branch
from
35a33b0
to
4ca4047
Compare
in typeorm#6268 we pulled in a change that fixed the wrong FK getting loaded in a multi-database / multi-schema environment but in typeorm#6169 the approach was more desirable as it creates a simpler query that should be easier to change in the future as such, this pulls over that change from typeorm#6169
imnotjames
force-pushed
the
refactor/rc-constraint-schema
branch
from
4ca4047
to
bdc7e66
Compare
|
I'm always super scary to merge changes on QueryRunners and SQLs used for schema sync. Let's merge it, but keep track on breaking change issues. |
|
👍 |
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
in typeorm#6268 we pulled in a change that fixed the wrong FK getting loaded in a multi-database / multi-schema environment but in typeorm#6169 the approach was more desirable as it creates a simpler query that should be easier to change in the future as such, this pulls over that change from typeorm#6169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #6268 we pulled in a change that fixed the wrong FK
getting loaded in a multi-database / multi-schema environment
but in #6169 the approach was more desirable as it creates
a simpler query that should be easier to change in the future
as such, this pulls over that change from #6169