feat: backport ilike from next #6862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ILike is not supported in oracle. Need to disable that test for oracle |
|
HMM, one of the mainline drivers don't support it either but I'm not sure which one. I'll have to check locally and then publish a change to the tests to disable. |
It would be great I think to quickly understand from CI what exact driver failed, to improve our developer experience. |
|
Definitely - a big reason why it's difficult is because of how we've structured our tests, with the |
imnotjames
force-pushed
the
feat/ilike
branch
3 times, most recently
from
91b9872
to
7dd5426
Compare
the next branch has support for ilike and this backports the FindOperator into the main branch
|
Thank you! |
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
the next branch has support for ilike and this backports the FindOperator into the main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the next branch has support for ilike and this backports
the FindOperator into the main branch