fix(data-api): Fixed how data api driver uses and reuses a client #6869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
requested changes
Oct 8, 2020
src/driver/aurora-data-api-pg/AuroraDataApiPostgresQueryRunner.ts
Outdated
Show resolved
Hide resolved
|
Oof, because this is the aurora stuff we don't have tests for it. Also, is there a related github issue? |
Yeah it runs a couple of statements like enabling postgres extensions. |
I have tests in the driver repository. This is a fix for a bug that was reported there as well (ArsenyYankovsky/typeorm-aurora-data-api-driver#5) |
imnotjames
reviewed
Oct 9, 2020
imnotjames
approved these changes
Nov 11, 2020
|
Given we can't really test this, I think it's good to merge in. 🤷 |
edcolvin
pushed a commit
to edcolvin/typeorm
that referenced
this pull request
Nov 12, 2020
…peorm#6869) Now each queryRunner will have it's own client which will allow it to handle transactions correctly.
nebkat
pushed a commit
to nebkat/typeorm
that referenced
this pull request
Jan 9, 2021
…peorm#6869) Now each queryRunner will have it's own client which will allow it to handle transactions correctly.
nebkat
pushed a commit
to nebkat/typeorm
that referenced
this pull request
Jan 9, 2021
…peorm#6869) Now each queryRunner will have it's own client which will allow it to handle transactions correctly.
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
…peorm#6869) Now each queryRunner will have it's own client which will allow it to handle transactions correctly.
|
@ArsenyYankovsky would have been nice to keep the transactionId inside queryRunner instead of client |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now each queryRunner will have it's own client which will allow it to handle transactions correctly.