fix: redundant migration with decimal default #6879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
reviewed
Oct 9, 2020
imnotjames
reviewed
Oct 9, 2020
test/functional/migrations/generate-command/entity/post.entity.ts
Outdated
Show resolved
Hide resolved
jeiea
force-pushed
the
fix-decimal-default
branch
from
3809634
to
8c69390
Compare
jeiea
changed the title
jeiea
force-pushed
the
fix-decimal-default
branch
from
8c69390
to
8bc4695
Compare
imnotjames
reviewed
Oct 11, 2020
jeiea
force-pushed
the
fix-decimal-default
branch
from
8bc4695
to
3c18bf5
Compare
|
Failure was an issue with circleci - kicking the tests :) Should work after that! |
imnotjames
reviewed
Oct 11, 2020
jeiea
force-pushed
the
fix-decimal-default
branch
2 times, most recently
from
e7dd6f4
to
2b1f6b5
Compare
imnotjames
approved these changes
Oct 11, 2020
MySQL/MariaDB decimal column is represented like '0.0'. MysqlDriver.normalizeDefault didn't consider trailing zeros. User can bypass this by passing default as string, but we can't guide the zeros by type, so we should convert user input. undefined scale was compared with defined scale. Skip this comparison. Close typeorm#6140 Close typeorm#5407
jeiea
force-pushed
the
fix-decimal-default
branch
from
2b1f6b5
to
b1e8fcc
Compare
|
Wonderful. Thanks for the contribution! |
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
MySQL/MariaDB decimal column is represented like '0.0'. MysqlDriver.normalizeDefault didn't consider trailing zeros. User can bypass this by passing default as string, but we can't guide the zeros by type, so we should convert user input. undefined scale was compared with defined scale. Skip this comparison. Close typeorm#6140 Close typeorm#5407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MySQL/MariaDB decimal column is represented like '0.0'.
MysqlDriver.normalizeDefault didn't consider trailing zeros.
User can bypass this by passing default as string, but we
can't guide the zeros by type, so we should convert user input.
Close #6140
Close #5407