-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Use Optimized Queries for MySQLQueryRunner.loadTables #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
force-pushed
the
perf/mysql-loadtable
branch
from
October 11, 2020 03:05
49f3bf5
to
5ac0f45
Compare
Queries executed are as follows:
@ronits-cx What do you think? |
imnotjames
changed the title
perf: Improve MySQL LoadTables Performance
perf: Use Optimized Queries for MySQL.loadTables
Oct 11, 2020
imnotjames
changed the title
perf: Use Optimized Queries for MySQL.loadTables
perf: Use Optimized Queries for MySQLQueryRunner.loadTables
Oct 11, 2020
@imnotjames 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how we make queries against the MySQL
INFORMATION_SCHEMA
metadata tables to follow the performance guidelines in the MySQL documentation. This means that the queries are a LITTLE weird, but I included pretty verbose comments on the implementation.I did an
EXPLAIN
of every query that this generates & runs - each one requires the minimum amount of data to operate on & doesn't scan the database directories.This is verified via the tests in other locations that it's working still - Not sure the best technique to verify this.
closes #6820
fixes #6800