Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct type for MongoQueryRunner.databaseConnection #6906

Merged
merged 1 commit into from
Oct 15, 2020
Merged

fix: use correct type for MongoQueryRunner.databaseConnection #6906

merged 1 commit into from
Oct 15, 2020

Conversation

imnotjames
Copy link
Contributor

it was using Db but instead it's actually MongoClient. Confirmed via the API docs for node-mongo, static analysis, and runtime verification.

fixes #6453

@pleerock pleerock merged commit da70b40 into typeorm:master Oct 15, 2020
@pleerock
Copy link
Member

Thank you!

@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 16, 2020
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
@imnotjames
fix: use correct type for MongoQueryRunner.databaseConnection (typeor…
93a7646 
…m#6906)

fixes typeorm#6453
@imnotjames imnotjames deleted the fix/mongo-driver-client-type branch June 21, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
hacktoberfest-accepted label hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MongoQueryRunner.databaseConnection is declared with a wrong type
2 participants
@imnotjames @pleerock