Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle undefined querysets in QueryCommand #6910

Merged
merged 1 commit into from
Oct 16, 2020
Merged

fix: Handle undefined querysets in QueryCommand #6910

merged 1 commit into from
Oct 16, 2020

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Oct 15, 2020 •
edited

When a query fails and returns undefined instead of an actual query set the QueryCommand has a TypeError.

fixes #6612

@pleerock pleerock merged commit 6f285dc into typeorm:master Oct 16, 2020
@pleerock
Copy link
Member

Thank you!

@imnotjames imnotjames deleted the fix/highlight-failed-query branch October 16, 2020 05:47
@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 16, 2020
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
@imnotjames
fix: Handle undefined querysets in QueryCommand (typeorm#6910)
e33b155 
fixes typeorm#6612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleerock pleerock pleerock left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted label hacktoberfest
Projects
None yet
Milestone
No milestone
2 participants
@imnotjames @pleerock