fix: handle Undefined values in driver URL options #6925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `buildDriverOptions` parses the URL & will have undefined values which it ends up overwriting non-undefined values with - which isn't great
imnotjames
changed the title
imnotjames
changed the title
imnotjames
changed the title
21 tasks
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
the `buildDriverOptions` parses the URL & will have undefined values which it ends up overwriting non-undefined values with - which isn't great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Driver URLs are passed without a database or with other options missing this change will prevent them from overriding explicitly defined values with their undefined values.
fixes #6900