fix: allow falsey discriminator values #6973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow discriminator values in Single Table Inheritance like 0, "", or `null` fixes typeorm#3891
imnotjames
force-pushed
the
feat/discriminator-value
branch
from
9521fc2
to
544a3a5
Compare
dolsup
pushed a commit
to dolsup/typeorm
that referenced
this pull request
Nov 3, 2020
allow discriminator values in Single Table Inheritance like 0, "", or `null` fixes typeorm#3891
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
allow discriminator values in Single Table Inheritance like 0, "", or `null` fixes typeorm#3891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This allows discriminator values in Single Table Inheritance - such as 0, "", or
nullBefore, if you attempted to use a discriminator for
0you'd receive errors about an invaliddiscriminator value, or the metadata just wouldn't register correctly.
Now, you can use a discriminator value that's "falsey" but not
undefined.fixes #3891
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000Documentation has been updated to reflect this changeN/A