transactional events in subscriber interface #6996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test for event listeners; updated docs;
|
@imnotjames I'm going to merge this one and release a new version. Do you want to review it before I do that? |
imnotjames
approved these changes
Nov 2, 2020
Comment on lines
+62
to
+65
| /** | ||
| * If this is set to true, SELECT query in a `find` method will be executed in a transaction. | ||
| */ | ||
| transaction?: boolean |
There was a problem hiding this comment.
I'm assuming this was intentionally added but seems to be a separate feature from the rest of this PR
There was a problem hiding this comment.
oh yeah I forgot I need to create a separate branch for this separate feature
yes it does, and here is why: when you run: START TRANSACTION
SELECT * FROM user
COMMITyou execute: entity.beforeTransactionStart()
entity.afterTransactionStart()there is no "entity" before SELECT on which we can call |
dolsup
pushed a commit
to dolsup/typeorm
that referenced
this pull request
Nov 3, 2020
…tion in FindOptions (typeorm#6996) * added new decorators * added hooks to etnity subscriber interface * added test code in one query runner * removed new decorators and implemented in subscriber instead * added "transaction" option to FindOneOptions * added event listeners in query runners; added test for event listeners; updated docs; * working on test; * working on test; * added test for `transaction` option; * fixing failing test * fixing failing test * fixing typos * fixing test I broke Co-authored-by: Dmitry Zotov <dmzt08@gmail.com>
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
…tion in FindOptions (typeorm#6996) * added new decorators * added hooks to etnity subscriber interface * added test code in one query runner * removed new decorators and implemented in subscriber instead * added "transaction" option to FindOneOptions * added event listeners in query runners; added test for event listeners; updated docs; * working on test; * working on test; * added test for `transaction` option; * fixing failing test * fixing failing test * fixing typos * fixing test I broke Co-authored-by: Dmitry Zotov <dmzt08@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.