feat: relations: Orphaned row action #7105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adenhertog <andrew.denhertog@gmail.com>
|
Wow implementation was much simpler than I thought. |
7 tasks
4 tasks
This was referenced Mar 8, 2021
|
Just used this feature, super useful. Thank you. |
|
Does not trigger AfterRemove listener on removed entity. |
7 tasks
|
Good feature, thanks for implementing! |
7 tasks
zshipleyTAG
pushed a commit
to Amherst-Development/typeorm
that referenced
this pull request
Oct 7, 2022
* typeorm-0.2.30: (212 commits) version bump docs: fix javascript usage examples (typeorm#7031) fix: resolve migration for UpdateDateColumn without ON UPDATE clause (typeorm#7057) fix: Error when sorting by an embedded entity while using join and skip/take (typeorm#7082) fix: resolves Postgres sequence identifier length error (typeorm#7115) feat: closure table custom naming (typeorm#7120) feat: relations: Orphaned row action (typeorm#7105) docs: fix invalid code block in "find many options" (typeorm#7268) docs: Embodying the example (typeorm#7116) docs: document withDeleted option (typeorm#7132) fix: return 'null' (instead of 'undefined') on lazy relations that have no results (typeorm#7146) (typeorm#7147) docs: update cascade options (typeorm#7140) docs: add .ts to supported ormconfig formats (typeorm#7139) fix: improve stack traces when using persist executor (typeorm#7218) refactor: remove Oracle multirow insert workaround (since typeorm#6927) (typeorm#7083) feat: add NOWAIT and SKIP LOCKED lock support for MySQL (typeorm#7236) docs: update OneToMany grammar (typeorm#7252) feat: JavaScript file migrations output (typeorm#7253) docs: update Repository.ts (typeorm#7254) chore: update dependency cli-highlight to v2.1.10 (typeorm#7265) ...
|
but this is for OneToMany Relations only. ManyToMany does not work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #1665 with some modifications.
Per @adenhertog from the original PR:
This adds an additional option on one-to-many relationships where child entities are deleted, rather than having their foreign key set to null, when removed from their parent.
Many times we have the situation where a parent entity "owns" a child. An example of this is when a User has a set of
RoleAssignmentin the context of permissions. When aRoleAssignmentis removed from the user, we expect for the row to be deleted. Previously the row would remain in the database but with theuserIdcolumn set tonull, leaving an orphaned row that would clog up the table.This fix allows for
RoleAssignmentto specify on its relationship withUserthat it should be deleted, rather than orphaned, when the relationship is removed.By default, the original behaviour of setting the foreign key to
nullis retained.See also #6704, and other issues taken from it:
Closes #1761
Closes #2467
Closes #5645
Related #1286
Related #1351
Related #6382
Description of change
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000