fix,feat: support MongoDB DNS seed list connection #7136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in [MongoDB Docs](https://docs.mongodb.com/manual/reference/connection-string/#dns-seed-list-connection-format), an additional connection string format called DNS Seed List Connection format can be used. As this is the default format for MongoDB Atlas, the hosted service of MongoDB, this should be available also for typeorm. The connection format is identified by the url-schema "mongodb+srv" and does not allow specifying a port. Fixes typeorm#3347 Fixes typeorm#3133
|
This should be merged asap. |
|
Could this be merged ? |
|
Please merge and release. |
|
This hasn't been rejected, the maintainers just haven't gotten around to merging it, and more comments won't make it any faster. Use the 👍 on the original PR instead of spamming. |
|
Thank you contribution and sorry for waiting! Fix will be available in v0.2.30 later this week. |
|
@pleerock Thanks. Can we know the exact date? |
1 task
This was referenced Mar 15, 2021
|
Dose this support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in MongoDB Docs, an additional connection string format called DNS Seed List Connection format can be used. As this is the default format for MongoDB Atlas, the hosted service of MongoDB, this should be available also for typeorm.
The connection format is identified by the url-schema "mongodb+srv" and does not allow specifying a port.
Description of change
When using the DNS seed connection list format,
mongodb+srvmust be used as URL schema and a port must not be provided!Can simply be verified with a free account of MongoDB Atlas, where this connection format is the default when using MongoDB driver 3.6+
Fixes #3347
Fixes #3133
Fixes #7009
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000