New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github issue 7178: order should allow only model fields, not methods #7188

Merged

pleerock merged 1 commit into typeorm:master from rysi3k:bugfix/github-7178

Dec 22, 2020

Contributor

rysi3k commented Dec 14, 2020

Description of change

In "order" clause it should be possible only to pass field-names, not methods.
Fixes: #7178

Pull-Request Checklist

Code is up-to-date with the master branch
npm run lint passes with this change
npm run test passes with this change
This pull request links relevant issues as Fixes #0000
There are new or updated unit tests validating the change
Documentation has been updated to reflect this change
The new commits follow conventions explained in CONTRIBUTING.md


          fix: order should allow only model fields, not methods

ced2133

Closes: typeorm#7178

pleerock merged commit 0194193 into typeorm:master

Member

pleerock commented Dec 22, 2020

Thank you for contribution! 🎉

This was referenced Mar 15, 2021

Bump typeorm from 0.2.29 to 0.2.31 mattwelke/typeorm-postgres-example#165

Merged

build(deps): bump typeorm from 0.2.29 to 0.2.31 DonNy88/nestjs-movie-catolg#329

Closed

⬆️ Bump typeorm from 0.2.29 to 0.2.31 parlemonde/1village#20

Closed

Bump typeorm from 0.2.25 to 0.2.31 newerton/gobarber-2-backend#17

Merged

chore(deps): bump typeorm from 0.2.29 to 0.2.31 smarlhens/nest-boilerplate#32

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment