Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing "comment" field to QueryExpressionMap.clone() method #7205

Conversation

astritsh
Copy link
Contributor

@astritsh astritsh commented Dec 17, 2020

Closes: #7203

Description of change

Added missing "comment" filed to QueryExpressionMap.clone() method.
In my understanding, clone method should copy every field, including the "comment" one.
Seems that clone() method was not updated after adding "comment" field to QueryExpressionMap.
In my case I have used "comment" for something special and when calling getManyAndCount(), count query was missing the "comment".
Added a unit test to confirm that clone method copies comment as well.

Pull-Request Checklist

  • [x ] Code is up-to-date with the master branch
  • [ x] npm run lint passes with this change
  • npm run test passes with this change
  • [x ] This pull request links relevant issues as Fixes #7203
  • [x ] There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • [ x] The new commits follow conventions explained in CONTRIBUTING.md

@pleerock pleerock merged commit f019771 into typeorm:master Dec 22, 2020
@pleerock
Copy link
Member

Thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryExpressionMap's clone method is missing copying "comment" field
3 participants