Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not add NULL/NOT NULL for stored columns #7708

Merged
merged 2 commits into from Jun 21, 2021
Merged

fix: Do not add NULL/NOT NULL for stored columns #7708

merged 2 commits into from Jun 21, 2021

Conversation

tomlaws
Copy link
Contributor

@tomlaws tomlaws commented Jun 3, 2021

Description of change

Avoid adding NULL/NOT NULL when creating STORED columns in MariaDB

Closes: #7698

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames merged commit 3c33e9f into typeorm:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnotjames imnotjames imnotjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MariaDB STORED columns don't accept [NULL | NOT NULL]
2 participants
@tomlaws @imnotjames