Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: entity object undefined in afterUpdate subscriber #7724

Merged
merged 1 commit into from Jul 15, 2021
Merged

fix: entity object undefined in afterUpdate subscriber #7724

merged 1 commit into from Jul 15, 2021

Conversation

francescoferraioli
Copy link
Contributor

@francescoferraioli francescoferraioli commented Jun 9, 2021 •
edited

Description of change

Similar to #5443, just for the afterUpdate subscribers.

This, alongside #5443 should fix the bug raised in #2809 and #2246.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #2809
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@francescoferraioli francescoferraioli mentioned this pull request Jun 9, 2021
Closed
7 tasks
@francescoferraioli francescoferraioli changed the title Pass the entity through on afterUpdate Pass the entity through on afterUpdate Jun 9, 2021
@francescoferraioli francescoferraioli changed the title Pass the entity through on afterUpdate fix: entity object undefined in afterUpdate subscriber Jun 9, 2021
@francescoferraioli francescoferraioli force-pushed the fix-issue-2809 branch 2 times, most recently from 205376a to 89ef0c0 Compare June 9, 2021 07:34
imnotjames
imnotjames approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@imnotjames imnotjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me and the tests look good.

@francescoferraioli francescoferraioli mentioned this pull request Jun 22, 2021
Merged
7 tasks
@francescoferraioli
Copy link
Contributor Author

@imnotjames - is there any further reason not to accept this PR?

@francescoferraioli
Copy link
Contributor Author

Thanks for approving @imnotjames. I can't merge it in myself. Is it something you need to do?

@imnotjames imnotjames merged commit d25304d into typeorm:master Jul 15, 2021
@francescoferraioli francescoferraioli deleted the fix-issue-2809 branch July 15, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnotjames imnotjames imnotjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francescoferraioli @imnotjames