fix: correctly load yml in ConnectionOptionsYmlReader #7743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
force-pushed
the
fix/7531/js-yaml-load
branch
2 times, most recently
from
b0e3804
to
2e426b0
Compare
|
Somebody using yml 🤔 |
this uses the correct `load` function instead of `loadAll`
imnotjames
force-pushed
the
fix/7531/js-yaml-load
branch
from
2e426b0
to
7259b0f
Compare
|
Seems that way. I saw it as an easy fix but the tests are weird because they compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
this uses the correct
loadfunction instead ofloadAllFixes #7531
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000