Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using custom index for MySqlDriver. #7755

Merged
merged 2 commits into from Nov 9, 2021
Merged

Support using custom index for MySqlDriver. #7755

merged 2 commits into from Nov 9, 2021

Conversation

and1truong
Copy link
Contributor

Description of change

Support using custom index for MySQLDriver.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #7754
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

mrsinguyen
mrsinguyen approved these changes Jun 22, 2021
View reviewed changes
Copy link

@mrsinguyen mrsinguyen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is looking good.

@pleerock
Copy link
Member

pleerock commented Nov 9, 2021

Looks good, thanks for contribution!

@pleerock pleerock merged commit f79ae58 into typeorm:master Nov 9, 2021
@and1truong and1truong deleted the use-custom-index branch November 10, 2021 08:41
HeartPattern pushed a commit to HeartPattern/typeorm that referenced this pull request Nov 29, 2021
@pleerock @HeartPattern
feat: support using custom index with SelectQueryBuilder in MySQL (ty…
a7a6e23 
…peorm#7755)

* Support using custom index for MySqlDriver.

* Update select-query-builder.md

Co-authored-by: Umed Khudoiberdiev <pleerock.me@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsinguyen mrsinguyen mrsinguyen approved these changes

@javidnoutash javidnoutash javidnoutash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@and1truong @pleerock @mrsinguyen @javidnoutash