Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: find operation in MongoDB do not include nullable values from documents #7820

Merged
merged 1 commit into from Jun 30, 2021
Merged

fix: find operation in MongoDB do not include nullable values from documents #7820

merged 1 commit into from Jun 30, 2021

Conversation

SnapeEye
Copy link
Contributor

@SnapeEye SnapeEye commented Jun 30, 2021 •
edited

fix: find operation in MongoDB do not include nullable values from documents

Find operation should add all nullable values from documents if they exist

Closes: #7760

Description of change

In current solution, when you perform find operation for MongoDB, nullable values are missing in final entities generated from our documents data. This PR is fixing this problem, adding all nullable values from documents if they exist making find operation.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@SnapeEye
fix: find operation in MongoDB do not include nullable values from do…
690a9d9 
…cuments

Find operation should add all nullable values from documents if they exist

Closes: typeorm#7760
@imnotjames
Copy link
Contributor

✔️ Tests
✔️ Minimal changes needed

🎉 Wonderful.

@imnotjames imnotjames merged commit 98c13cf into typeorm:master Jun 30, 2021
@imnotjames
Copy link
Contributor

Thanks for the contribution!

@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Jul 2, 2021
Merged
7 tasks
@imnotjames imnotjames mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imnotjames imnotjames imnotjames approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mongodb: When field is null in db, typeorm query sets it to undefined
2 participants
@SnapeEye @imnotjames