Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use char(36) for uuid representation in mysql #7853

Merged
merged 1 commit into from Jul 11, 2021
Merged

feat: use char(36) for uuid representation in mysql #7853

merged 1 commit into from Jul 11, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 7, 2021 •
edited

Description of change

uses CHAR(36) for all uuid types in MySQL.

fixes #7228

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames force-pushed the feat/7228/uuid-char-length branch 3 times, most recently from bace24a to fbe6fb5 Compare July 7, 2021 03:49
@imnotjames imnotjames marked this pull request as draft July 7, 2021 04:58
@imnotjames imnotjames mentioned this pull request Jul 7, 2021
Merged
7 tasks
@imnotjames imnotjames marked this pull request as ready for review July 7, 2021 15:56
@imnotjames imnotjames merged commit 063aafa into typeorm:master Jul 11, 2021
@imnotjames imnotjames deleted the feat/7228/uuid-char-length branch July 11, 2021 05:36
@Diluka Diluka mentioned this pull request Aug 2, 2021
Closed
@Diluka Diluka mentioned this pull request Sep 6, 2021
Open
@mpvosseller mpvosseller mentioned this pull request Oct 19, 2021
Open
pleerock added a commit that referenced this pull request Nov 9, 2021
@pleerock
Revert "feat: use char(36) for uuid representation in mysql (#7853)"
ab882ba 
This reverts commit 063aafa.
@pleerock pleerock mentioned this pull request Nov 9, 2021
Merged
pleerock added a commit that referenced this pull request Nov 9, 2021
@pleerock
revert: "feat: use char(36) for uuid representation in mysql (#7853)" (…
1588c58 
…#8343)

This reverts commit 063aafa.
HeartPattern pushed a commit to HeartPattern/typeorm that referenced this pull request Nov 29, 2021
@pleerock @HeartPattern
revert: "feat: use char(36) for uuid representation in mysql (typeorm…
ea8fc49 
…#7853)" (typeorm#8343)

This reverts commit 063aafa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@Column({ type: "uuid" }) should be varchar(36) on MySQL instead of varchar(255)
1 participant
@imnotjames