Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable returning additional columns with MSSQL #7864

Merged
merged 2 commits into from Jul 8, 2021
Merged

fix: enable returning additional columns with MSSQL #7864

merged 2 commits into from Jul 8, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 8, 2021 •
edited

Description of change

fixes #7100
closes #7101

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames force-pushed the fix/7100/mssql-returning-columns branch 2 times, most recently from 9fddb85 to f916ccd Compare July 8, 2021 05:30
@imnotjames imnotjames changed the title Fix/7100/mssql returning columns fix: enable returning additional columns with MSSQL Jul 8, 2021
@imnotjames imnotjames marked this pull request as ready for review July 8, 2021 06:39
@imnotjames imnotjames force-pushed the fix/7100/mssql-returning-columns branch from f916ccd to 3d04c7e Compare July 8, 2021 20:07
@imnotjames imnotjames force-pushed the fix/7100/mssql-returning-columns branch from 3d04c7e to adc486b Compare July 8, 2021 20:11
@imnotjames imnotjames merged commit e1db48d into typeorm:master Jul 8, 2021
@imnotjames imnotjames deleted the fix/7100/mssql-returning-columns branch July 8, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL Server error when requesting additional returning columns
2 participants
@imnotjames @nebkat