Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: craft oracle connectString as a descriptor #7878

Merged
merged 1 commit into from Jul 9, 2021
Merged

fix: craft oracle connectString as a descriptor #7878

merged 1 commit into from Jul 9, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 9, 2021 •
edited

Description of change

this allows us to more explicitly pass the SID correctly as the SID

fixes #5408

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames
fix: craft oracle connectString as a descriptor
b390bcc 
this allows us to more explicitly pass the SID correctly as the SID
@imnotjames imnotjames marked this pull request as ready for review July 9, 2021 20:07
@imnotjames imnotjames merged commit b05d093 into typeorm:master Jul 9, 2021
@imnotjames imnotjames deleted the fix/5408/oracle-sid-mix-up branch July 9, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sid and serviceName for oracledb config are mixed up
1 participant
@imnotjames