Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle snake case of ABcD which should become a_bc_d #7883

Merged
merged 1 commit into from Jul 10, 2021
Merged

fix: handle snake case of ABcD which should become a_bc_d #7883

merged 1 commit into from Jul 10, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 10, 2021 •
edited

Description of change

handles an edge case for the snake case code to be more comprehensive

this also simplifies the regular expressions

fixes #4387
closes #7870

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames
fix: handle snake case of ABcD which should become a_bc_d
5ff0c46 
this also simplifies the regular expressions
@imnotjames imnotjames force-pushed the fix/4387/snake-case-function-misses branch from 4b0a673 to 5ff0c46 Compare July 10, 2021 21:28
@imnotjames imnotjames merged commit eb680f9 into typeorm:master Jul 10, 2021
@imnotjames imnotjames deleted the fix/4387/snake-case-function-misses branch July 10, 2021 21:59
@meganoob1337
Copy link

This is a Breaking Change: #8173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snake case function not matching repeating groups
2 participants
@imnotjames @meganoob1337