Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: foreign keys in SAP were loading from the wrong table #7914

Merged

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 15, 2021

Description of change

the REFERENCED_TABLE_NAME was being pulled from dbTable instead of dbForeignKey where that field actually exists.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames merged commit 4777a79 into typeorm:master Jul 15, 2021
@imnotjames imnotjames deleted the fix/0000/sap-incorrect-referenced-value branch July 15, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant