Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support fully qualified schema in createSchema #7934

Merged
merged 1 commit into from Jul 20, 2021
Merged

fix: support fully qualified schema in createSchema #7934

merged 1 commit into from Jul 20, 2021

Conversation

imnotjames
Copy link
Contributor

Description of change

this allows passing database.schema in all createSchema calls.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames merged commit 94edd12 into typeorm:master Jul 20, 2021
@imnotjames imnotjames deleted the fix/7867/consistent-create-and-drop-schema branch July 20, 2021 06:21
imnotjames added a commit to imnotjames/typeorm that referenced this pull request Jul 21, 2021
@imnotjames
fix: support fully qualified schema in createSchema (typeorm#7934)
da55925
imnotjames added a commit to imnotjames/typeorm that referenced this pull request Jul 21, 2021
@imnotjames
fix: support fully qualified schema in createSchema (typeorm#7934)
752e01a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@imnotjames