Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve query for MSSQL to fetch foreign keys and tables #7935

Merged
merged 1 commit into from Jul 20, 2021
Merged

fix: improve query for MSSQL to fetch foreign keys and tables #7935

merged 1 commit into from Jul 20, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 20, 2021 •
edited

Description of change

these changes ensure that the forieng keys and tables we pull from
SQL Server are the correct ones we were looking for even if they have
the same name as objects in other databases

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames
fix: improve query for MSSQL to fetch foreign keys and tables
9fa0daa 
these changes ensure that the forieng keys and tables we pull from
SQL Server are the correct ones we were looking for even if they have
the same name as objects in other databases
@imnotjames imnotjames marked this pull request as ready for review July 20, 2021 06:14
@imnotjames imnotjames merged commit f6af01a into typeorm:master Jul 20, 2021
@imnotjames imnotjames deleted the fix/7867/mssql-query-fixes branch July 20, 2021 06:15
imnotjames added a commit to imnotjames/typeorm that referenced this pull request Jul 21, 2021
@imnotjames
fix: improve query for MSSQL to fetch foreign keys and tables (typeor…
62a4cbe 
…m#7935)

these changes ensure that the forieng keys and tables we pull from
SQL Server are the correct ones we were looking for even if they have
the same name as objects in other databases
imnotjames added a commit to imnotjames/typeorm that referenced this pull request Jul 21, 2021
@imnotjames
fix: improve query for MSSQL to fetch foreign keys and tables (typeor…
cec91b3 
…m#7935)

these changes ensure that the forieng keys and tables we pull from
SQL Server are the correct ones we were looking for even if they have
the same name as objects in other databases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@imnotjames