Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oracle cannot support DB in table identifiers #7954

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 25, 2021

Description of change

oracle queries cannot support the identifier including the database in this way (XE.SYSTEM.table)

Instead, if you should specify a separate database a link must be set up and then
the database link identifier is included after the table. (SYSTEM.table@XE)

However, because that's rather difficult to set up lets not for now & just prevent
inclusion of the database in the case that we fetch it.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames merged commit 8c60d91 into typeorm:master Jul 25, 2021
@imnotjames imnotjames deleted the fix/0000/oracle-table-name-shouldnt-have-database branch July 25, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant