Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly handle multiple-row insert for SAP HANA driver #7957

Merged
merged 1 commit into from Feb 16, 2022
Merged

fix: correctly handle multiple-row insert for SAP HANA driver #7957

merged 1 commit into from Feb 16, 2022

Conversation

imnotjames
Copy link
Contributor

Description of change

the SAP HANA SQL dialect does not support inserts with multiple values
but it does support INSERT ... SELECT as well as a SELECT ... FROM dummy

with that in mind, the InsertQueryBuilder has been modified to support
this dialect similar to how we do for Oracle

fixes #7899

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames
fix: correctly handle multiple-row insert for SAP HANA driver
43184c4 
the SAP HANA SQL dialect does not support inserts with multiple values
but it does support `INSERT ... SELECT` as well as a `SELECT ... FROM dummy`

with that in mind, the `InsertQueryBuilder` has been modified to support
this dialect similar to how we do for Oracle
@imnotjames imnotjames marked this pull request as draft July 25, 2021 18:39
@imnotjames
Copy link
Contributor Author

needs tests somehow..

@niels-schmitt niels-schmitt mentioned this pull request Oct 12, 2021
Closed
17 tasks
@pleerock pleerock marked this pull request as ready for review February 16, 2022 13:59
@pleerock
Copy link
Member

Okay so I guess it's completed, but just missing tests. Let's merge the functionality and add tests later.

@pleerock pleerock merged commit 8f2ae71 into typeorm:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL syntax error occurs by typeorm insert of multiple rows into table for sap (HANA) database
2 participants
@imnotjames @pleerock