Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use js rather than ts in all browser package manifests #7982

Merged
merged 1 commit into from Jul 30, 2021
Merged

fix: use js rather than ts in all browser package manifests #7982

merged 1 commit into from Jul 30, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 30, 2021 •
edited

Description of change

some of the items in the browser field in the package manifest mistakenly used .ts extensions
instead of .js. This caused us to not replace the drivers during build time when we should
have.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames force-pushed the fix/7976/fix-browser-replacements branch from ba81295 to 8b0ade7 Compare July 30, 2021 03:39
@imnotjames imnotjames merged commit 0d90bcd into typeorm:master Jul 30, 2021
@imnotjames imnotjames deleted the fix/7976/fix-browser-replacements branch July 30, 2021 04:26
@imnotjames imnotjames mentioned this pull request Jul 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@imnotjames