feat: add possibility to pass application_name via postgres specific config #7989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imnotjames
requested changes
Jul 30, 2021
das-mensch
force-pushed
the
feature/postgres-application-name
branch
2 times, most recently
from
514551e
to
779ee59
Compare
shrujalshah28
suggested changes
Jul 30, 2021
…config as the "extra" parameter should be deprecated in the future, the need for passing driver specific options via the respective config objects is given. This change also enables the user to use code completion in case they didn't even knew this options exists
add useful information about the parameter and show its default value
das-mensch
force-pushed
the
feature/postgres-application-name
branch
from
779ee59
to
12766c6
Compare
imnotjames
approved these changes
Jul 30, 2021
shrujalshah28
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As the "extra" parameter should be deprecated in the future, the need for
passing driver specific options via the respective config objects is given.
The addition of the "applicationName" parameter is a step forward in this
direction. This parameter is visible in logs and statistics and helps db
administrators to see which connection belongs to which application.
This change also enables the user to use code completion in case they
didn't even knew this options exists
Pull-Request Checklist
masterbranchnpm run lintpasses with this changenpm run testpasses with this changeFixes #0000N/A