Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: throw error when not connected in drivers #7995

Merged
merged 1 commit into from Jul 31, 2021
Merged

fix: throw error when not connected in drivers #7995

merged 1 commit into from Jul 31, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 31, 2021 •
edited

Description of change

this updates a few of the drivers to explicitly throw an error if they've not been connected but they attempt to obtain an actual connection

fixes #7208

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames merged commit cd71f62 into typeorm:master Jul 31, 2021
@imnotjames imnotjames deleted the fix/7208/error-when-not-connected branch July 31, 2021 04:49
@imnotjames imnotjames mentioned this pull request Aug 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read property 'connect' of undefined at ./node_modules/typeorm/driver/postgres/PostgresDriver.js:831:26
1 participant
@imnotjames